Add fallback for dark theme when localStorage isn't available#613
Open
mayankkamboj47 wants to merge 2 commits intopubliclab:mainfrom
Open
Add fallback for dark theme when localStorage isn't available#613mayankkamboj47 wants to merge 2 commits intopubliclab:mainfrom
mayankkamboj47 wants to merge 2 commits intopubliclab:mainfrom
Conversation
Make the dark theme work on browsers that have disabled cookies and localStorage access
|
Thanks for opening this pull request! |
Author
|
@publiclab/reviewers I do not have anything to ask except that, perhaps the last point shouldn't be a list-item to check ? (Okay, now I can check the last item) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the dark theme work on browsers that have disabled cookies and localStorage access
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment below